Add strip_invalid_metadata argument to validator normalize method #355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 This update adds the
strip_invalid_metadata
argument to the publicnormalize
method, passing the argument into the nonpublic_normalize
method rather than always passing false.The reason behind this change is that the _normalize method only uses the
relax_add_props
argument whenstrip_invalid_metadata
is true. That argument is currently hardcoded to false bynormalize
, making therelax_add_props
argument functionality unused. By allowing callers to specifystrip_invalid_metadata
, there is at least a chance that therelax_add_prop
argument will also be used.I didn't see any tests in this project related to the normalize method, so I wasn't sure what might be needed for tests.